Skip to content

Promote unsafe event to send frags #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
louisponet merged 1 commit into from
May 19, 2025
Merged

Promote unsafe event to send frags #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions optimism/op-node/rollup/engine/engine_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@ func (e *EngineController) BackupUnsafeL2Head() eth.L2BlockRef {
}

func (e *EngineController) IsEngineSyncing() bool {
// return e.syncStatus == syncStatusWillStartEL || e.syncStatus == syncStatusStartedEL || e.syncStatus == syncStatusFinishedELButNotFinalized
return true
return e.syncStatus == syncStatusWillStartEL || e.syncStatus == syncStatusStartedEL || e.syncStatus == syncStatusFinishedELButNotFinalized
}

// Setters
Expand Down
2 changes: 1 addition & 1 deletion optimism/op-node/rollup/engine/events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,7 @@ func (d *EngDeriver) OnEvent(ev event.Event) bool {
"unsafe_timestamp", x.Unsafe.Time)
d.emitter.Emit(EngineResetConfirmedEvent(x))
case PromoteUnsafeEvent:
d.preconfChannels.SendL2Block(&x.Ref)
// Backup unsafeHead when new block is not built on original unsafe head.
if d.ec.unsafeHead.Number >= x.Ref.Number {
d.ec.SetBackupUnsafeL2Head(d.ec.unsafeHead, false)
Expand Down Expand Up @@ -498,7 +499,6 @@ func (d *EngDeriver) OnEvent(ev event.Event) bool {
d.emitter.Emit(PromoteSafeEvent(x))
}
case PromoteSafeEvent:
d.preconfChannels.SendL2Block(&x.Ref)
d.log.Debug("Updating safe", "safe", x.Ref, "unsafe", d.ec.UnsafeL2Head())
d.ec.SetSafeHead(x.Ref)
// Finalizer can pick up this safe cross-block now
Expand Down
Loading