Skip to content

add Timer::record_scoped RAII guard #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartoszmodelski merged 2 commits into from
May 21, 2026
Merged

add Timer::record_scoped RAII guard #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8dd4dd
add Timer::record_scoped RAII guard
bartoszmodelski May 21, 2026
ba22488
mark record_scoped as #[must_use]
bartoszmodelski May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions crates/flux-communication/src/timer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@ impl Timer {
self.emit_processing();
}

#[inline]
#[must_use = "the returned guard records on drop; binding it to `_` drops it immediately"]
pub fn record_scoped(&mut self) -> ScopedRecord<'_> {

@niki4smirn niki4smirn May 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#[must_use]

just in case :)

self.start();
ScopedRecord { timer: self }
}

/// Finish processing, then emit upstream latency.
///
/// Processing interval:
Expand Down Expand Up @@ -248,6 +255,17 @@ impl Timer {
}
}

pub struct ScopedRecord<'a> {
timer: &'a mut Timer,
}

impl Drop for ScopedRecord<'_> {
#[inline]
fn drop(&mut self) {
self.timer.record_processing();
}
}

/// Used by timeit macro
#[allow(dead_code)]
pub static TIMERS: LazyLock<Mutex<HashMap<&'static str, Timer>>> =
Expand Down
Loading