Skip to content

better handling of cursors & no more forced backlog draining#87

Merged
louisponet merged 4 commits into
mainfrom
lopo/active_groups
Jun 7, 2026
Merged

better handling of cursors & no more forced backlog draining#87
louisponet merged 4 commits into
mainfrom
lopo/active_groups

Conversation

@louisponet

@louisponet louisponet commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Clears out old pid cursors earlier.
makes a function to cacl how many msgs can be sent without speeding past anyone
Also no more forced backlog draining

@louisponet louisponet requested a review from a team June 7, 2026 08:02

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread crates/flux-communication/src/queue/mod.rs Outdated
Comment thread crates/flux-communication/src/queue/mod.rs
Comment thread crates/flux-communication/src/queue/mod.rs

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment thread crates/flux-communication/src/queue/mod.rs
Comment thread crates/flux-communication/src/queue/mod.rs
Update the dead-PID group test for active_groups filtering and the intended single-loop slot reclamation behavior. Add a regression test showing max_writable_msgs_without_speeding_past reports the exact number of writes that can occur before a broadcast consumer would be overwritten.
@louisponet louisponet changed the title better handling of cursors better handling of cursors & no more forced backlog draining Jun 7, 2026
@louisponet louisponet merged commit e06914b into main Jun 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants