Scanning malicious files before upload#7
Open
shubhamj99 wants to merge 1 commit intogauranshkumar:masterfrom
Open
Scanning malicious files before upload#7shubhamj99 wants to merge 1 commit intogauranshkumar:masterfrom
shubhamj99 wants to merge 1 commit intogauranshkumar:masterfrom
Conversation
Owner
|
@shubhamj99 There is a small issue in the PR The possible solution to this could be not reading the files as binary rather sending the FIleObject as it is or as a byte stream. |
Owner
|
Also, Is this key in the commit belongs to you, if yes then please don't share it in public and use a secure way to use it maybe by exporting the key as an Environment Variable and using it via |
Author
|
Ok I'll look into this, I didn't get that error before. Thanks for the feedback. |
Owner
|
Sure 👍🏼 |
Owner
|
Hey, @shubhamj99 any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"this commit fixes #6 "