Skip to content

feat: Add text support for ogre 2#1304

Open
jmachowinski wants to merge 2 commits into
gazebosim:mainfrom
cellumation:text_support
Open

feat: Add text support for ogre 2#1304
jmachowinski wants to merge 2 commits into
gazebosim:mainfrom
cellumation:text_support

Conversation

@jmachowinski

@jmachowinski jmachowinski commented Jun 25, 2026

Copy link
Copy Markdown

🎉 New feature

Closes #1264

Summary

Fully vibe coded port of the ogre 1 text support.

grafik

Backport Policy

  • This is safe to backport to the following versions:
    • Jetty
    • Ionic
    • Harmonic
    • Fortress
  • This should not be backported
  • I am not sure
  • Other (fill in yourself)

Test it

You will need some plugin etc to test and verify this.
The text_TEST more or less only test if it is not crashing,
but not the actual rendering.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the feature
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: GLM-5.2 SWE-1.6 Claude Opus 4.8

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

Signed-off-by: Janosch Machowinski <j.machowinski@cellumation.com>
@jmachowinski

Copy link
Copy Markdown
Author

The tests on homebrew are failing as USE_OGRE2_OVERLAY is disabled.

What is the best approach here, should I guard that test with an ifdef ?

@jmachowinski jmachowinski marked this pull request as draft June 25, 2026 17:05
@jmachowinski

Copy link
Copy Markdown
Author

I found some crashes if toggling visibility, setting to draft for now

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
@jmachowinski jmachowinski marked this pull request as ready for review June 29, 2026 08:53
@jmachowinski

Copy link
Copy Markdown
Author

The crash I was seeing was due to the need to remove geometries explicitly and not only the visual the geometry was attached to.

E.g. :

      // Without this line you will get a crash
      label.visual->RemoveGeometries();
      scene->RootVisual()->RemoveChild(label.visual);
      label.visual.reset();
    }

@iche033 Is this expected behavior or rather a bug in the visual ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

Scene::CreateText is not implemented for ogre2

2 participants