fix: broadcast newly-discovered orphan sessions to UI#136
Open
anish749 wants to merge 1 commit into
Open
Conversation
LogPoller#pollOnce inserted new orphan agent_sessions rows but only fired onSessionActivated / onSessionOrphaned, which are transition-only. First-time discoveries with no matching tmux window were silent, so the registry's history bucket never got populated until some unrelated event triggered updateDormantAgentSessions(). Add an onSessionsDiscovered callback fired at the end of pollOnce when orphans > 0, and wire it to updateDormantAgentSessions() alongside the existing callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135.
Problem
New orphan rows were inserted into
agent_sessionsbut never broadcast — the UI's history list stayed empty until some unrelated event happened to triggerupdateDormantAgentSessions().Fix
Add an
onSessionsDiscoveredcallback fired at the end ofpollOncewhenorphans > 0, wired toupdateDormantAgentSessions()next to the existingonSessionActivated/onSessionOrphanedcallbacks.Tests
Two new
logPoller.test.tscases:22/22 logPoller tests pass; lint and typecheck clean.