move to cmake build#137
Conversation
| cmake_minimum_required(VERSION 3.13) | ||
| # binjgb is using minimum 2.8 ... new cmake doesn't like it those lines silencing it | ||
| set(CMAKE_POLICY_DEFAULT_CMP0000 NEW) | ||
| set(CMAKE_POLICY_VERSION_MINIMUM 3.5) | ||
| set(CMAKE_WARN_DEPRECATED OFF CACHE BOOL "" FORCE) |
There was a problem hiding this comment.
I would expect that cmake_minimum_required(VERSION 3.13...3.24 FATAL_ERROR) should avoid the need for the extra silencing?
There was a problem hiding this comment.
hmmm well, we should try with newer binjgb version since binji/binjgb@3acf6da
There was a problem hiding this comment.
ok with 66d69e9
and
cmake_minimum_required(VERSION 3.13...3.24 FATAL_ERROR)
CMake Deprecation Warning at binjgb/CMakeLists.txt:5 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument <min> value or use a ...<max> suffix to tell
CMake that the project does not need compatibility with older versions.
I don't ike when build have any warning if they are not because my code
There was a problem hiding this comment.
Oh, perhaps 3.13...4.2 might work, then?
There was a problem hiding this comment.
with current main cmake_minimum_required(VERSION 3.13) is enough ... also main is now with banked breakpoints
There was a problem hiding this comment.
with cmake_minimum_required(VERSION 3.13...4.2 FATAL_ERROR) still the same
i mean ... we can remove this and then update binjgb
# binjgb is using minimum 2.8 ... new cmake doesn't like it those lines silencing it
set(CMAKE_POLICY_DEFAULT_CMP0000 NEW)
set(CMAKE_POLICY_VERSION_MINIMUM 3.5)
set(CMAKE_WARN_DEPRECATED OFF CACHE BOOL "" FORCE)
seems fair
Co-authored-by: Eldred Habert <me@eldred.fr>
Co-authored-by: Eldred Habert <me@eldred.fr>
…date binjgb there is no need for this
SelvinPL
left a comment
There was a problem hiding this comment.
we can live with this as we should update binjgb soon anyway
Closes #136