Skip to content

move to cmake build#137

Open
SelvinPL wants to merge 5 commits into
gbdev:masterfrom
SelvinPL:feature/cmake_build
Open

move to cmake build#137
SelvinPL wants to merge 5 commits into
gbdev:masterfrom
SelvinPL:feature/cmake_build

Conversation

@SelvinPL
Copy link
Copy Markdown
Contributor

@SelvinPL SelvinPL commented May 7, 2026

Closes #136

Comment thread .github/workflows/build.yml Outdated
Comment thread build.sh Outdated
Comment thread CMakeLists.txt Outdated
Comment on lines +1 to +5
cmake_minimum_required(VERSION 3.13)
# binjgb is using minimum 2.8 ... new cmake doesn't like it those lines silencing it
set(CMAKE_POLICY_DEFAULT_CMP0000 NEW)
set(CMAKE_POLICY_VERSION_MINIMUM 3.5)
set(CMAKE_WARN_DEPRECATED OFF CACHE BOOL "" FORCE)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect that cmake_minimum_required(VERSION 3.13...3.24 FATAL_ERROR) should avoid the need for the extra silencing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm well, we should try with newer binjgb version since binji/binjgb@3acf6da

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with 66d69e9

and
cmake_minimum_required(VERSION 3.13...3.24 FATAL_ERROR)

CMake Deprecation Warning at binjgb/CMakeLists.txt:5 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

I don't ike when build have any warning if they are not because my code

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, perhaps 3.13...4.2 might work, then?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with current main cmake_minimum_required(VERSION 3.13) is enough ... also main is now with banked breakpoints

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with cmake_minimum_required(VERSION 3.13...4.2 FATAL_ERROR) still the same

i mean ... we can remove this and then update binjgb

# binjgb is using minimum 2.8 ... new cmake doesn't like it those lines silencing it
set(CMAKE_POLICY_DEFAULT_CMP0000 NEW)
set(CMAKE_POLICY_VERSION_MINIMUM 3.5)
set(CMAKE_WARN_DEPRECATED OFF CACHE BOOL "" FORCE)

seems fair

SelvinPL and others added 3 commits May 8, 2026 20:36
Co-authored-by: Eldred Habert <me@eldred.fr>
Co-authored-by: Eldred Habert <me@eldred.fr>
Copy link
Copy Markdown
Contributor Author

@SelvinPL SelvinPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can live with this as we should update binjgb soon anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposition: change build from sh script to cmake for wasm builds

2 participants