Enable automatic generation of compiler flag list for Clang tooling#2008
Merged
Conversation
ISSOtm
added
enhancement
ISSOtm
marked this pull request as ready for review
July 5, 2026 15:36
Rangi42
requested changes
Jul 5, 2026
Rangi42
left a comment
Rangi42
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good! A few suggestions and questions.
Rangi42
approved these changes
Jul 11, 2026
Contributor
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1995, removing one source of truth for our flags.
I have considered removing
REAL{CXX,LD}FLAGSand replacing them with the three variables, but idk if that's desirable.