RGBGFX reverse mode checks for too-low palette IDs, not just too-high#2024
Merged
Conversation
Rangi42
marked this pull request as ready for review
July 14, 2026 01:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to fix the sanity checks for invalid input into RGBGFX reverse mode. Specifically, we should ensure that the tilemap's tile IDs and the attribute map's palette IDs are valid, even with nonzero base tile/palette IDs specified.
However, I'm having trouble getting that to cooperate with therandtilegen/rgbgfx_testrandomized test cases. Sometimes they fail, as in https://github.com/Rangi42/rgbds/actions/runs/29282085627/job/86927774014:Edit: Turns out it was a mistake in 21eaa2d, which 8b951bc has fixed. I confirmed this by locally editing
test/gfx/test.shto iterate over every possible$ofsvalue ("All 30723 tests passed!").