Switch to use the upstream source code of visit_struct#58
Merged
Conversation
Collaborator
|
Actually, the modification of cbeck88/visit_struct#14 are useful for the weird initialization of https://github.com/ami-iit/matio-cpp/blob/12022e5fae6127cea7b3f957899e32cf36a30882/test/ExogenousConversionsUnitTest.cpp#L56-L64. It is not mentioned in the README either. We started using |
S-Dafarra
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches to use a commit on the
upstreambranch ofami-iit's fork ofvisit_struct. That branch is created by cherry-picking the CMake structured added in ami-iit/visit_struct#1 on the top of the latest commit of the master branch of https://github.com/garbageslam/visit_struct, that gotVISITABLE_INITin https://github.com/garbageslam/visit_struct/pull/24/files .Using the upstream source code of
visit_structwould simplify packaging the library in conda-forge . However, as far as I understood the code is different between https://github.com/garbageslam/visit_struct/pull/24/files and cbeck88/visit_struct#14, so we may want to merge with care. The tests ofmatio-cppare passing fine, but I do not know if there is something else we want to check before merging.