Suggest minor re-organization while working on windows implementation#38
Open
ghost wants to merge 8 commits intogchp:masterfrom
Open
Suggest minor re-organization while working on windows implementation#38ghost wants to merge 8 commits intogchp:masterfrom
ghost wants to merge 8 commits intogchp:masterfrom
Conversation
added 8 commits
June 26, 2015 02:40
|
Exciting 🐰 |
Owner
|
Sorry for the delay in reviewing this, been a bit short of time recently! I've not had a chance to run this just yet, as soon as I do I'll update again. Thanks for submitting! |
Author
|
Just ignore this one, I have to pull in the recent changes for stable support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've gotten a lot of the Windows implementation working in a separate repository.
Since the Linux termbox wrapper and the windows version are implemented very differently (for now), I recommend keeping the two implementations in separate directories, and conditionally compile based on OS, until they become more merged.
I modified the source for conditional compilation and the cargo file to set appropriate dependencies for each platform.