Open
Conversation
…so works on Safari.
…ad of 'effectAllowed' in InputWaiter and RecipeWaiter
This was
linked to
issues
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using CyberChef with macOS Safari I noticed two issues.
When dragging an operation from the Operations panel to the Recipe panel, the description popover reappears mid-drag over the Recipe section. This prevents dropping the operation because the popover re-shows itself and visually/functionally blocks the drop.
It's not possible to drop an Operation onto the Favorites item. This was earlier reported in issues Bug report: Edit favorites in Safari #1602 and Bug report: <Safari issue> #1710. A comment under that second issue mentions a workaround where holding the
⌘ Commandbutton while dragging fixes this issue. However, it would be better to just support default dragging, like it does on Chrome.Here's a screen grab showing both issues (note that at the end I show the workaround, by holding the
⌘ Commandbutton while dragging):CyberChef_SafariDragIssues.mp4
I looked into these issues and managed to fix them both. I introduced the flag
dragInProgress, that is used to keep track of the dragging operation. This bypasses Safari's handling of theeffectAllowedproperty and some weirdness related toMouseEvent.buttons.I tested this on the latest versions of Safari and Chrome running on macOS Tahoe 26.3.1 and it seems to work just fine on both.