Conversation
Summary of ChangesHello @darsoo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves as a test, primarily demonstrating a minor version increment within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the package version to a development version, 1.9.4.0001. While this is a valid format, I've suggested aligning with a more common R package development convention for versioning to improve clarity. For future pull requests, please consider providing a more descriptive title and body to clearly communicate the purpose of the changes. It is also a good practice to create a corresponding entry in the NEWS.md file for the new development version to track upcoming changes.
| Type: Package | ||
| Title: A package with helper functions for processing drug response data | ||
| Version: 1.9.4 | ||
| Version: 1.9.4.0001 |
There was a problem hiding this comment.
While 1.9.4.0001 is a valid development version, it is a common convention in R package development to use a higher number for the fourth component, such as .9000. This convention, promoted by tools like usethis, helps to clearly signal that this is a development version. Adopting this convention improves clarity for developers and aligns with community best practices.
Version: 1.9.4.9000
Test only!
No plan to merge it
No review needed