resources: Update readme to point to resources#56
Open
Harshil2107 wants to merge 1 commit intogem5:stablefrom
Open
resources: Update readme to point to resources#56Harshil2107 wants to merge 1 commit intogem5:stablefrom
Harshil2107 wants to merge 1 commit intogem5:stablefrom
Conversation
powerjg
reviewed
Sep 18, 2024
Contributor
powerjg
left a comment
powerjg
left a comment
There was a problem hiding this comment.
This looks OK to me. The main problem will be: Will you remember to update this when you rebuild the resources?
Contributor
Author
|
I can update the links to be not resource version specific and so it will always point to the latest version of a resource in case we update it. If we want to make it version specific, I think would it be better to have a document that outlines what to update when a resource is updated? |
Contributor
|
Let's remove the version numbers. |
Contributor
Author
|
Ok, How do we want to handle the asm tests, as we have a lot (in hundreds) and it doesn't seem helpful to have over a hundred links. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.