-
Notifications
You must be signed in to change notification settings - Fork 20
feat: use directory structure that supports multiple features #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: use directory structure that supports multiple features #58
Conversation
Add warnings in all commands that use hot_reload to inform users about the known limitation on Flutter stable <= 3.37.0. This helps users understand why hot reload may fail and provides clear guidance on workarounds (switching to Flutter main channel or manually restarting the app). Changes: - Updated /debug-app command to check Flutter version early and warn users about hot reload limitations - Added inline warnings in /create-app and /modify commands when hot_reload is used - Updated CHANGELOG.md to document this improvement Related to gemini-cli-extensions#15
- Simplify verbose checklist in debug-app.toml to a single note - Remove issue gemini-cli-extensions#15 reference per reviewer request - Use "main" channel consistently (not "main/master") - Reword from "does not work" to "only works reliably" - Change "restarting" to "reloading" for accuracy
Addresses issue gemini-cli-extensions#8 by providing clear instructions to users when they ask to run their app but the launch_app tool is not available or fails. Users are directed to either use flutter run in a terminal or their IDE's Flutter extension.
Restructure specs directory to support multiple features with numbered directories. Each feature now gets its own subdirectory (e.g., 001-my-app) containing separate files for spec, data model, plan, tasks, and requirements. Changes: - Split DESIGN.md into spec.md, data-model.md, and plan.md - Rename IMPLEMENTATION.md to tasks.md - Add checklists/requirements.md for tracking requirements - Use three-digit numbered prefixes for feature directories Closes gemini-cli-extensions#47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new, more scalable directory structure for feature specifications, moving from single design files to a numbered directory per feature. This change is consistently applied across the create-app, create-package, and modify commands, improving organization. The changes are well-implemented, but I found one minor factual error in a version number that is repeated across several files. Please see the detailed comment. A helpful fallback instruction for running apps was also added, which is a nice addition.
Flutter version 3.37.0 does not exist - versions jump from 3.35.0 to 3.38.0. Hot reload became stable in Flutter 3.35.0, so this is the correct version to reference. Fixed in: create-app.toml, modify.toml, debug-app.toml, README.md
Summary
specs/directory to support multiple features with numbered directories (e.g.,specs/001-my-app/,specs/002-add-auth/)DESIGN.mdinto separate files:spec.md,data-model.md,plan.mdIMPLEMENTATION.mdtotasks.mdchecklists/requirements.mdfor tracking functional/non-functional requirementsNew Directory Structure
Benefits
Closes #47