test(ai-sdk): scrub residual @rudderjs mentions from test comments#52
Merged
Conversation
These were explanatory comments describing what the in-process test fakes mimic (cache adapter surface, a sync seed helper). No imports or deps. Removing them makes the engine source literally free of any @rudderjs reference, the last acceptance gate for the decouple epic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final tidy for the decouple epic (#35). After #49 and #51, the only
@rudderjsstrings left inpackages/ai-sdk/srcwere three explanatory comments in test files describing what the in-process fakes mimic (the cache adapter surface; a sync seed helper). No imports, no deps, no behavior.Reworded them to be framework-neutral so the epic's acceptance gate is literally true:
Test-comment-only, so no changeset (nothing to publish).