Skip to content

feat: add tool decorator#387

Open
akihikokuroda wants to merge 9 commits intogenerative-computing:mainfrom
akihikokuroda:issue382
Open

feat: add tool decorator#387
akihikokuroda wants to merge 9 commits intogenerative-computing:mainfrom
akihikokuroda:issue382

Conversation

@akihikokuroda
Copy link
Member

@akihikokuroda akihikokuroda commented Jan 30, 2026 •
edited
Loading

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@mergify
Copy link

mergify bot commented Jan 30, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@nrfulton nrfulton removed the request for review from HendrikStrobelt January 31, 2026 00:20
jakelorocco
jakelorocco reviewed Feb 2, 2026
View reviewed changes
mellea/backends/tools.py Outdated
Comment on lines 210 to 212
# Extract MelleaTool from decorated functions
if hasattr(tool_instance, "_mellea_tool"):
tool_instance = tool_instance._mellea_tool
Copy link
Contributor

@jakelorocco jakelorocco Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be able to pass in the decorated function directly since it's typed as a MelleaTool and has all the same properties?

@akihikokuroda
Copy link
Member Author

akihikokuroda commented Feb 2, 2026

@jakelorocco Thanks for review. I think all comments are addressed.

jakelorocco
jakelorocco requested changes Feb 3, 2026
View reviewed changes
jakelorocco
jakelorocco reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

@jakelorocco jakelorocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think I missed this in the last review or the overloading changed it. I think after this change we should be good. Thank you!

mellea/backends/tools.py Outdated
Comment on lines 94 to 95
@overload
def tool(func: Callable) -> MelleaTool: ...
Copy link
Contributor

@jakelorocco jakelorocco Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add , *, name: str | None = None to this function definition so that you can still change the tool name when you call it on a function directly:

def new_tool(): ...

differently_named_tool = tool(new_tool, name="different_name")

@akihikokuroda akihikokuroda force-pushed the issue382 branch 3 times, most recently from 4095165 to 1393dad Compare February 5, 2026 23:09
@akihikokuroda
add tool decorator
63def8b 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
review comments
decc803 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
fix merge error
c34511f 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
fix lint error
8354455 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
review comments
c3385ec 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
review comment
d9f5250 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
review comment
b55eda2 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
review comment
9f81dcf 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda
review comment
e998fb2 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakelorocco jakelorocco jakelorocco requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: add decorators for mellea tools

2 participants

@akihikokuroda @jakelorocco