fix: Bumps to transformers==5.0.0#418
fix: Bumps to transformers==5.0.0#418nrfulton wants to merge 1 commit intogenerative-computing:mainfrom
Conversation
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
|
@guicho271828 Why do we have a version pin for transformers in the vllm dependency? |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
Just a heads up, when I tried bumping the transformers version it opened a whole can of worms: it required a vllm bump, which required a bump to outlines, which would've required code changes in the backends. |
7de778d to
32fcaab
Compare
Yeah. The vllm/outlines thing seems like we should be able to work-around. @guicho271828 has already looked into removing outlines entirely. Now might be the time to do that if we need to make changes to bump the version. There's also a transformers v4 dependency in docling; I'm not sure what their status is on supporting the latest transformers, though. I think those are the only two blockers. They are both pretty annoying blockers, though :( |
Bump to transformers v5
Type of PR
Description
transformers==4.57.6and also figure out a migration path for legacy cache code #367This PR updates our KV smash code to use transformers v5. This requires moving away form the Legacy Cache implementation. The code here is originally from @csbobby.
This PR is still a draft. There are several changes needed:
Testing