904 feature request randall eten make options for cluster or individual exporting#1004
Merged
LeviXIII merged 14 commits intoJun 4, 2026
Conversation
Third step in the exporter only for audio in bible files to select only specific milestone (chapters) to download during the export.
…s-for-cluster-or-individual-exporting
LeviXIII
reviewed
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Functionality is good. There is one issue and one text suggestion that I found though:
-
For older projects, I don't get the step for milestone exporting. We need to have a way for older projects to see this step. It's hit or miss as both projects didn't have an importerType, but one was able to see the step while the other wasn't.
-
For the Select Milestones description, we don't need to include "All milestones are selected by default" as we can see all the checkboxes checked off and the "Select All" checkbox checked. You can remove that sentence.
…mismatch modal (#998) Consolidates the three modal fixes for the "Files Without Audio/Text" export warning that were previously split across two PRs (#1002, #1003): - Scrollable file list: cap .popup-file-list at 40vh with overflow-y:auto so a long list scrolls instead of overflowing past the viewport. - Aligned icons: vertically center each file icon with its filename (display:flex; align-items:center on the list rows). - OK button: add a primary OK button at the bottom-right of the content-mismatch modal so users have an obvious dismiss action beyond the small X. CSS changes apply to both the content-mismatch and HTML-mismatch popups via the shared .popup-file-list class. Supersedes #1002 and #1003. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The first pass capped only the inner .popup-file-list, which left .popup-card free to grow past the viewport and could push the new OK button off-screen. Switch to the standard scrollable-modal pattern: cap the card at 85vh as a flex column, scroll the .popup-body (overflow-y:auto; min-height:0), and pin the header and footer (flex-shrink:0) so the OK button stays visible. Verified with a headless-Chromium render of the popup CSS: with 60 files the body scrolls (scrollHeight 1552 > clientHeight 520) and the OK button stays in view at both 700px and 420px window heights; with 4 files it correctly does not scroll. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Make .popup-body a non-scrolling flex column with the summary/note paragraphs pinned (flex-shrink:0) and only .popup-file-list absorbing overflow (flex:0 1 auto; min-height:0; overflow-y:auto). The list stays compact for short lists and scrolls internally for long ones, while the header, surrounding text, and OK button stay fixed. Verified via headless-Chromium render: with 60 files only the list scrolls (body not scrollable) and summary/note/OK button stay visible at 700px and 420px window heights; with 4 files nothing scrolls. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Halve the height at which the Files Without Audio/Text list starts scrolling by adding max-height:26vh to .popup-file-list, so it tops out at roughly half its previous height (~373px -> ~198px at a 700px window) and scrolls from there. Surrounding text, header, and OK button are unaffected. Verified via headless-Chromium render. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Quill's built-in `matchText` clipboard matcher collapses runs of 2+ ASCII spaces into a single space when converting HTML → Delta on cell open. For scripture translation, every character is meaningful: double spaces in imported source text (e.g. the Portuguese project) were silently dropped in the open editor view while still present in the closed-cell display, making them appear "hidden" and uneditable. Fixes this at the root by: 1. Swapping Quill's built-in TEXT_NODE matcher for a non-destructive variant in `utils/preserveWhitespace.ts`. Mirrors Quill 2.0.3's matchText exactly minus the offending collapse line; all other semantics (Word `<o:p>` handling, `<pre>` passthrough, leading/ trailing-space stripping at block boundaries, NBSP normalization) are preserved. The matcher is located by function reference so a future Quill reordering doesn't silently re-introduce the bug. 2. Restoring `.ql-editor`'s `white-space` to `pre-wrap` (Quill's actual default) so the now-preserved spaces render visibly while editing. Adds a vitest regression suite that exercises the matcher against a real Quill instance to catch any future Quill upgrade that breaks the splice. If upstream PR slab/quill#4319 ever lands, `utils/preserveWhitespace.ts` and the splice in `Editor.tsx` can be removed entirely.
- Create issue templates
LeviXIII
reviewed
Jun 3, 2026
Contributor
LeviXIII
left a comment
LeviXIII
left a comment
There was a problem hiding this comment.
One new issue:
- If I have 2 books that are exporting audio (Gen and Mat) and then I unselect all the books from Mat. and just take one chapter from Gen, Mat still exports the first milestone available.
…s-for-cluster-or-individual-exporting
LeviXIII
reviewed
Jun 3, 2026
Contributor
LeviXIII
left a comment
LeviXIII
left a comment
There was a problem hiding this comment.
2 John doesn't seem to be give me an option to download by milestone while 2 Peter does. In fact, you may want to take a look at books with just one chapter as they seem to be acting up (eg. Jude gives me two chapter 1s)
LeviXIII
approved these changes
Jun 4, 2026
LeviXIII
deleted the
904-feature-request-randall-eten-make-options-for-cluster-or-individual-exporting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added ability for bible files to export audio in "milestones" (chapters). there will be a third step to select what milestones to include for audio export (it will not mess up the text export, that will work normally for the whole file as it always does).