Adding a delete confirmation for urls and video files#1032
Open
TimRl wants to merge 2 commits into
Open
Conversation
…r having removed it (whether url or video)
Contributor
Author
|
/build |
|
Pre-release: 0.27.0-pr1032-07e0bc6 https://github.com/genesis-ai-dev/codex-editor/releases/tag/0.27.0-pr1032-07e0bc6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1031-Adding a delete confirmation for urls and video files
#1031
Project: 1032-delete-video-safely
Summary
Removing or replacing a chapter video previously took effect with only a single, easily-dismissed native confirmation — risky because removing a local video permanently deletes the file from the project on save. This PR adds a robust "type-to-confirm" safety gate in the Edit Metadata modal: to remove a video, the user must type or paste the exact file name (local) or URL (remote) before the removal is enabled. It also removes the now-redundant second confirmation that fired afterward, so the user confirms exactly once.
Changes
These should match with the Acceptance Criteria
Enterconfirms when matched;Escapecancels just the confirmation without closing the modal; the input auto-focuses.skipVideoConfirmflag), since the modal now performs a stronger confirmation. The host still deletes the old file, and keeps the prompt as a fallback for any non-modal caller.Testing Checklist
files/andpointers/; "Show Video" toggle disappears.