Ben/fix sparkle#855
Open
BenjaminScholtens wants to merge 4 commits into
Open
Conversation
Implemented a new function to determine if a source notebook cell has a resolvable audio file for transcription. This ensures that the "Transcribing source audio…" message is only displayed when transcription can actually occur. Updated message handling to incorporate this check before processing audio transcription requests.
… is empty Implemented a new test case to verify that the LLM completion process correctly skips source transcription when the source cell is empty and no source audio exists. This ensures that the system behaves as expected under these conditions, preventing unnecessary operations and improving efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found an error where llm completions won't trigger properly for some abnormal cases. This adds a proper check.