Allow dev extensions with a pinned project (adjust pin version check)#874
Open
JonahBraun wants to merge 4 commits into
Open
Allow dev extensions with a pinned project (adjust pin version check)#874JonahBraun wants to merge 4 commits into
JonahBraun wants to merge 4 commits into
Conversation
The gate was comparing the running extension version against the pin, which false-fires when a dev extension shadows the installed VSIX — the dev version (e.g. 0.24.0) differs from the pin (e.g. 0.24.0-pr856-…), so activation halted permanently with no reload ever coming. Switch to getPinMismatches, which asks the Conductor whether the pinned version is installed in the active profile (via getInstalled()). Dev extensions are invisible to getInstalled(), so the gate correctly answers "would the right version be running if there were no dev extension?".
JonahBraun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dev extension shadows the installed VSIX,
failsPinMatchGatewas comparing the running extension version (e.g.0.24.0from the dev extension'spackage.json) against the pin (e.g.0.24.0-pr856-e368f60e). These never match, so activation halted permanently — but the Conductor saw no mismatch (the VSIX in the profile was correct) and never triggered a reload. Result: stuck on "Starting Project Synchronization (Version Pin Enforcement)" forever.The gate should answer "would the right version be running if there were no dev extension?" — which is exactly what
getPinMismatchesanswers, since it usesgetInstalled()and dev extensions are invisible to that API.Changes
failsPinMatchGatenow callscodex.conductor.getPinMismatchesinstead ofgetEffectivePinnedExtensions+getCurrentExtensionVersionTesting
Starting Project Synchronization (Version Pin Enforcement)even though the correct extension was installed in the project