914 allow for exporting audio while using stream only#941
Merged
LeviXIII merged 17 commits intoMay 28, 2026
Conversation
Enabled audio export when users are in stream only, using the same logic as our playback feature.
…into 914-allow-for-exporting-audio-while-using-stream-only
…into 914-allow-for-exporting-audio-while-using-stream-only
Fixing the issue #917
Contributor
Author
Contributor
|
/build |
|
Pre-release: 0.27.0-pr941-a0919dc https://github.com/genesis-ai-dev/codex-editor/releases/tag/0.27.0-pr941-a0919dc |
TimRl
previously requested changes
May 8, 2026
Contributor
TimRl
left a comment
TimRl
left a comment
There was a problem hiding this comment.
Batch downloading of the files should be implemented. It downloads extremely slow compared to other downloads in Codex.
With added test
Contributor
|
/build |
|
Pre-release: 0.27.0-pr941-df0d2a2 https://github.com/genesis-ai-dev/codex-editor/releases/tag/0.27.0-pr941-df0d2a2 |
…lers - Added `audioAttachmentUtils.ts` for shared audio attachment handling, including functions to pick audio attachments and determine cell audio states. - Updated `audioExporter.ts` to utilize the new audio attachment utilities, enhancing audio export functionality. - Introduced `exportProgress.ts` to manage export progress reporting, allowing for better user feedback during export operations. - Refactored existing export functions in `htmlExporter.ts`, `plaintextExporter.ts`, and `usfmExporter.ts` to incorporate progress reporting. - Improved error handling and user notifications across export processes.
Remove cleanupInvalidAudioSelections so opening a cell no longer rewrites selectedAudioId or marks the document dirty. The audio history modal now shows the user’s real selection (explicitSelectedAudioId), even when that take is missing. Export and pre-flight no longer auto-pick the latest take: cells with recordings but no selection warn as “audio available, none selected”; cells whose selected take is gone warn as “selected audio is missing”.
Updated audio attachment utilities to deliberately ignore the `isMissing` flag during selection and resolution processes. This change ensures that user selections are preserved and not prematurely filtered out due to stale migration hints. Introduced a new utility function to clear the `isMissing` flag after successful audio resolution, enhancing the accuracy of audio state reporting in the editor and export processes.
- Extracted `formatCellDisplayLabel` and `extractCellTextSnippet` functions into a new `cellLabelUtils.ts` file for shared use between the audio exporter and export wizard's pre-flight scan. - Updated `exportAudioAttachments` to utilize the new labeling functions, ensuring consistent human-readable identifiers for cells in audio-missing reporting. - Improved handling of missing audio flags during export processes, aligning the user interface with the actual export state.
…d styling - Introduced a mechanism to manage a single active export panel, preventing duplicate instances when the export command is invoked multiple times. - Updated the styling of audio-stat counters for better visual affordance, ensuring they are clearly identifiable as interactive elements. - Enhanced accessibility features by adding ARIA attributes to buttons in the export view.
- Updated the `restoreMissingPointers` method to differentiate between LFS pointer text and raw media bytes in the `files/` directory. - Implemented logic to write zero-byte placeholders for raw media bytes, allowing for recovery during the next sync push. - Added tests to ensure correct behavior for both scenarios, verifying that pointers are mirrored or stubbed appropriately based on content type. - Improved documentation to clarify the rationale behind the changes and the handling of various audio attachment states.
Contributor
|
/build |
|
Pre-release: 0.27.0-pr941-02ed542 https://github.com/genesis-ai-dev/codex-editor/releases/tag/0.27.0-pr941-02ed542 |
Contributor
|
/build |
|
Pre-release: 0.27.0-pr941-58fee90 https://github.com/genesis-ai-dev/codex-editor/releases/tag/0.27.0-pr941-58fee90 |
- Added a new command "openCellInEditor" to facilitate navigation from the export view to specific cells in the codex editor. - Updated the `NotebookAudioStats` interface to include detailed cell entries with `label` and `cellId` for better identification. - Refactored related functions to handle the new data structure for audio stats cells. - Enhanced error handling for the new navigation feature.
Contributor
|
/build |
|
Pre-release: 0.27.0-pr941-d7796db https://github.com/genesis-ai-dev/codex-editor/releases/tag/0.27.0-pr941-d7796db |
Contributor
|
/build |
|
Pre-release: 0.27.0-pr941-8fa68cb https://github.com/genesis-ai-dev/codex-editor/releases/tag/0.27.0-pr941-8fa68cb |
LeviXIII
reviewed
May 28, 2026
LeviXIII
approved these changes
May 28, 2026
LeviXIII
deleted the
914-allow-for-exporting-audio-while-using-stream-only
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to export audio files for Stream Only. It uses similar approach as our playback feature.
Test Project: 941-allow-for-exporting-audio-while-using-stream-only
Tied to genesis-ai-dev/frontier-authentication#31