Skip to content

chore(js/core): Include key for all actions#5041

Merged
ifielker merged 2 commits intomainfrom
if-alwaysKey
Apr 2, 2026
Merged

chore(js/core): Include key for all actions#5041
ifielker merged 2 commits intomainfrom
if-alwaysKey

Conversation

@ifielker
Copy link
Copy Markdown
Collaborator

@ifielker ifielker commented Apr 1, 2026

Checklist (if applicable):

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a standardized key property for actions, formatted as /${type}/${name}, and ensures it is populated during registration and included in telemetry metadata. The changes update actionMetadata creation, the registry's action registration logic, and various tests to verify the genkit:key attribute in exported spans. One review comment suggests that registerActionAsync also needs to be updated to ensure consistency when namespaces are used, as it currently might report non-namespaced keys for actions registered asynchronously.

@ifielker ifielker requested a review from pavelgj April 2, 2026 18:35
@ifielker ifielker merged commit 93eb61b into main Apr 2, 2026
8 checks passed
@ifielker ifielker deleted the if-alwaysKey branch April 2, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants