Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a standardized key property for actions, formatted as /${type}/${name}, and ensures it is populated during registration and included in telemetry metadata. The changes update actionMetadata creation, the registry's action registration logic, and various tests to verify the genkit:key attribute in exported spans. One review comment suggests that registerActionAsync also needs to be updated to ensure consistency when namespaces are used, as it currently might report non-namespaced keys for actions registered asynchronously.
pavelgj
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):