feat(js/plugins/middleware): implemented skills middleware#5049
Open
pavelgj wants to merge 9 commits intopj/gm-middlware-package-retry-fallbackfrom
Open
feat(js/plugins/middleware): implemented skills middleware#5049pavelgj wants to merge 9 commits intopj/gm-middlware-package-retry-fallbackfrom
pavelgj wants to merge 9 commits intopj/gm-middlware-package-retry-fallbackfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new skills middleware for Genkit, which allows for scanning a directory of skill definitions (in Markdown format with frontmatter) and injecting them into the system prompt. It also provides a use_skill tool to retrieve the full content of a specific skill. While the implementation provides a solid foundation, several issues were identified regarding concurrency in the initialization logic, potential failures in frontmatter parsing due to line-ending differences, and the use of synchronous file I/O within the tool's execution which could block the event loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.