Skip to content

ci: gate node sync on a single approval #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dohernandez merged 1 commit into from
Apr 29, 2026
+3 −12
Merged

ci: gate node sync on a single approval #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Add this to a workflow in the genlayer-node repository:

Access to the private `genlayerlabs/genlayer-node` repository is provided by a GitHub App installed on that repository. The workflow mints a short-lived installation token via `actions/create-github-app-token@v3`.

Credentials live in the **`Node Sync`** GitHub Environment (Settings → Environments → Node Sync). Any job that needs the App token must declare `environment: Node Sync` at the job level — without it, `secrets.NODE_SYNC_APP_*` resolves to empty.
Credentials live in the **`Node Sync`** GitHub Environment (Settings → Environments → Node Sync), which has a Required-reviewers protection rule. To keep the gate to a **single approval per workflow run**, only the `prepare` job declares `environment: Node Sync`; it mints the App token once and exposes it as a job output (`needs.prepare.outputs.token`) for downstream jobs to consume. Adding a second job that declares the same environment would trigger a second approval — avoid that.

Required environment secrets:

Expand Down
13 changes: 2 additions & 11 deletions .github/workflows/sync-docs-from-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
environment: Node Sync
outputs:
version: ${{ steps.final_version.outputs.version }}
token: ${{ steps.app-token.outputs.token }}
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand All @@ -67,7 +68,6 @@ jobs:

- name: Generate GitHub App token
id: app-token
if: steps.extract.outputs.version == 'latest'
uses: actions/create-github-app-token@v3
with:
client-id: ${{ secrets.NODE_SYNC_APP_CLIENT_ID }}
Expand Down Expand Up @@ -100,7 +100,6 @@ jobs:
name: 'Sync Files'
runs-on: ubuntu-latest
needs: prepare
environment: Node Sync
strategy:
matrix:
sync_type: [changelog, config, config_asimov, config_bradbury, docker_compose, docker_compose_monitoring, alloy_config, greybox_setup, api_gen, api_debug, api_ops]
Expand All @@ -117,19 +116,11 @@ jobs:
sudo wget -qO /usr/local/bin/yq https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64
sudo chmod +x /usr/local/bin/yq

- name: Generate GitHub App token
id: app-token
uses: actions/create-github-app-token@v3
with:
client-id: ${{ secrets.NODE_SYNC_APP_CLIENT_ID }}
private-key: ${{ secrets.NODE_SYNC_APP_KEY }}
repositories: genlayer-node

- name: Clone source repository
uses: actions/checkout@v4
with:
repository: genlayerlabs/genlayer-node
token: ${{ steps.app-token.outputs.token }}
token: ${{ needs.prepare.outputs.token }}
fetch-depth: 1
sparse-checkout: |
docs
Expand Down
Loading