Merged
Conversation
In the setup of the device, the keys were initialized to ``` [Codes.KeyA .. Codes.KeyZ] ++ [Codes.Key1 .. Codes.Key0] ``` But that is incorrect: `KeyA` corresponds to value 30 and `KeyZ` corresponds to value 44; this therefore excludes keys such as `KeyB` (48) and others. This can be observed by running the example and typing `abcde`; only `ad` will be echoed back. Perhaps the better fix would be to modify the `Enum` instance, but that might result in difficult to debug backwards incompatibility problems, so this PR simply fixes the example.
Owner
|
🤦♂️ Not sure how I failed to notice this! I'm not convinced that an alternative Perhaps the library could provide "event groups", like Anyway, thanks for the fix! |
Contributor
Author
|
Indeed, such groups would be useful and might even prevent some bugs, certainly had me stumped for a while why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the setup of the device, the keys were initialized to
But that is incorrect:
KeyAcorresponds to value 30 andKeyZcorresponds to value 44; this therefore excludes keys such asKeyB(48) and others. This can be observed by running the example and typingabcde; onlyadwill be echoed back.Perhaps the better fix would be to modify the
Enuminstance, but that might result in difficult to debug backwards incompatibility problems, so this PR simply fixes the example.