Send keypresses when a text input is submitted (Linux only)#36
Open
georgefst wants to merge 2 commits into
Open
Send keypresses when a text input is submitted (Linux only)#36georgefst wants to merge 2 commits into
georgefst wants to merge 2 commits into
Conversation
georgefst
commented
Sep 2, 2021
|
|
||
| type E = Map LayoutID (Device, LayoutMeta) | ||
| type S = (Device, LayoutMeta) | ||
| type S = ((Device, LayoutMeta), Text) |
| '7' -> Just Key7 | ||
| '8' -> Just Key8 | ||
| '9' -> Just Key9 | ||
| 'a' -> Just KeyA |
Owner
Author
There was a problem hiding this comment.
Handle capitals by inserting KeyShift?
| ClientUpdate (SliderMove i x) -> | ||
| lookup' #sliderMap i . onAxis $ x * 2 - 1 | ||
| ClientUpdate (InputText _ t) -> do | ||
| (#extra % _2) .= t |
Owner
Author
There was a problem hiding this comment.
We should track each text input element separately. In fact, really the frontend should track this state anyway - see #35.
| _ -> Nothing | ||
|
|
||
| keyToChar :: Key -> Maybe Char | ||
| keyToChar = \case |
Owner
Author
There was a problem hiding this comment.
DRY this with the above. Maybe by constructing a top level list of pairs, and two maps.
| keyUnknown = KeyUnknown | ||
|
|
||
| charToKey :: Char -> Maybe Key | ||
| charToKey = \case |
Owner
Author
There was a problem hiding this comment.
This is probably incomplete. Complete it and maybe upstream to evdev?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs some cleaning up.