fix: prevent favicon-group crashes from malformed source URLs#16
Open
georgestander wants to merge 1 commit into
Open
fix: prevent favicon-group crashes from malformed source URLs#16georgestander wants to merge 1 commit into
georgestander wants to merge 1 commit into
Conversation
georgestander
added
codex
Contributor
Changelog PreviewNo valid changelog bullets were found under Add at least one bullet in the PR body, or apply the Checked on 2026-03-03T06:05:59.256Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new URL(source.url)usage fromFaviconGroupunknown)getGoogleFaviconUrlhelper for robust favicon URL generationValidation
pnpm exec vitest run components/favicon-group.test.ts lib/url-utils.test.ts