Improves pure-Python ECI/ECEF accuracy#105
Open
ryanpavlick wants to merge 2 commits intogeospace-code:mainfrom
Open
Improves pure-Python ECI/ECEF accuracy#105ryanpavlick wants to merge 2 commits intogeospace-code:mainfrom
ryanpavlick wants to merge 2 commits intogeospace-code:mainfrom
Conversation
…ipsoid and some additional functions in nvector.py; along with associated tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the non-AstroPy ECI/ECEF path by replacing the old single sidereal-rotation fallback with a more complete Earth-orientation model.
What changed
eci2ecef()/ecef2eci()fallback to use that modeldelta_ut1,xp, andypthrough higher-level wrappersAccuracy and performance
On the existing sample case, the pure-Python fallback error drops from kilometer-scale to meter-scale relative to Astropy.
This does make the fallback slower than before because it now computes leap-second handling, TT/UT1-related quantities, precession, nutation, sidereal rotation, and optional polar motion instead of a single sidereal rotation.
On local benchmarks for the pure-Python fallback:
eci2ecef()calls were about 12.6x slowerThe tradeoff here is intentionally accuracy over raw speed for the non-AstroPy path.
Testing
All tests pass. Adds a new EOP roundtrip test and tightens existing ECI/ECEF fallback tests.