Open
Conversation
Owner
|
I'm d'accord, except with commit acc8cf8. The function is protected, and we can not be sure it hasn't been overridden by some application or library. Indeed, PageData is handed over as parameter in case subclasses need access to it. |
gerdriesselmann
approved these changes
Dec 13, 2020
gerdriesselmann
approved these changes
Dec 13, 2020
gerdriesselmann
approved these changes
Dec 13, 2020
gerdriesselmann
approved these changes
Dec 13, 2020
gerdriesselmann
approved these changes
Dec 13, 2020
gerdriesselmann
requested changes
Dec 13, 2020
Owner
gerdriesselmann
left a comment
gerdriesselmann
left a comment
There was a problem hiding this comment.
Method signatures of protected function should not change. Please revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.