Add MockAtmosphere.unfollow#78
Merged
Merged
Conversation
Mirrors follow/block: delegates to MockPDS.unfollow to remove a follow record, so tests can construct a "not followed" social-graph state. Requires the AtprotoClient release adding unfollow; the AtprotoClient pin must be bumped to that version (kept at from: 0.6.0 here since the release isn't cut yet). Verified locally against AtprotoClient's unfollow branch via a path override. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 14b007a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The automated release is blocked upstream, so `from: "0.6.0"` would resolve to a version without `unfollow`. Pin the revision to the #44 merge commit until AtprotoClient can cut a release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The automated release recovered and cut 0.7.0, so replace the temporary revision pin on the #44 merge commit with a `from: "0.7.0"` version pin. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
MockAtmosphere.unfollow(subjectDid:from:), mirroringfollow/block— it delegates toMockPDS.unfollowto remove the matching follow record, so a test can undo a follow and construct a "not followed" social-graph state.Stacked on germ-network/AtprotoClient#44 (which adds
MockPDS.unfollow/MockRepo.unfollow). This PR keeps theAtprotoClientpin atfrom: 0.6.0, so CI won't build until that release lands and the pin is bumped to it — please bump the pin on/after merging #44. Verified locally against #44's branch via a temporary path override.Motivation: germDM's anchor welcome route silence-and-relays a not-followed peer (distinct from a blocked peer, which drops); that path had no test because the harness couldn't produce the state.
Changeset: minor.