Preserve the body-decode error in ParseError#49
Merged
Conversation
The parse catch collapsed every decode failure into .unrecognized, which carries only the response headers — a well-formed 200 whose body failed to decode reported the same as an unknown status, hiding the DecodingError (and its coding path) that says what actually broke. Carry it in a new .undecodable case. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 7575e37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResponseParsing.parsecollapsed every thrown decode error into.unrecognized(HTTPResponse), which carries only the response headers — so a well-formed 200 whose body failed to decode reported identically to an unknown status, discarding theDecodingErrorand its coding path. This is what turned the unpadded-$bytesbug (#48) into a debugger session instead of a log read.Adds
ParseError.undecodable(HTTPResponse, underlying: any Error)and returns it from the catch. Additive only:ParseErroris consumed via specific-case catch patterns (e.g. AtprotoClient'scallExpectingOptional), so no existing matching changes behavior.🤖 Generated with Claude Code