Correct the conformance note: the PSK recipe is draft-02's#72
Merged
Conversation
The note predates PR #51, which moved the apq_psk onto the Safe Extensions recipe and added the APQInfo extension and AppDataUpdate attestation. It claimed the opposite of all three, contradicting wire-format.md and psk-binding.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Implemented binding" note in
protocol-flows.mdpredates the draft-02 conformance work (#51) and claimed the exact opposite of what the crate now does: a plain MLS exporter instead of the Safe Extensions recipe, and noAPQInfoextension,AppDataUpdateproposal, or attested epochs. All four claims are false —export_pskderives viaSafeExportSecret(0xFF01)+DeriveSecret, andwire-format.mdandpsk-binding.mdalready describe the current state correctly.The note now states the conformant recipe and points at the chapters that carry the detail, while keeping the two deviations that are still real:
APQInfois written once rather than rewritten (epoch freshness rides the per-commitAppDataUpdate), and the A.3 injected secret stays Germ's ownexternal(1)PSK. Also fixes the A.5 note's copy of the same stale claim and the A.1 diagram's oldpsk_idscheme.🤖 Generated with Claude Code