Draft
Conversation
guptamukund22
commented
Apr 1, 2025
guptamukund22
commented
- Refactored API client to introduce modular HTTP handlers (httpGet, httpPost, httpDelete) for improved code readability, maintainability, and reduced redundancy across API endpoint methods.
Contributor
|
most of the changes look irrelevant here. https://github.com/getAlby/js-sdk/blob/master/.vscode/settings.json we use prettier for formatting and enforce traillingComma rule on code formats. and i guess you just removed at most of the place. can you update this pr to undo this? |
Author
|
I have fixed the formatting issues using prettier. Please let me know if any other changes are needed. |
Contributor
|
Hi @guptamukund22 could you fix the conflict? and @pavanjoshi914 could you do a more thorough review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.