Skip to content

Comments

Add validation for WalletConnect connection strings#528

Open
naveenkumar29052006 wants to merge 2 commits intogetAlby:masterfrom
naveenkumar29052006:fix/validate-walletconnect-url
Open

Add validation for WalletConnect connection strings#528
naveenkumar29052006 wants to merge 2 commits intogetAlby:masterfrom
naveenkumar29052006:fix/validate-walletconnect-url

Conversation

@naveenkumar29052006
Copy link

@naveenkumar29052006 naveenkumar29052006 commented Feb 2, 2026

Fixes #527

This PR adds validation for WalletConnect connection strings to ensure invalid data is rejected early.

  • Validate required fields such as wallet pubkey and relay URLs
  • Optionally require the secret when initializing an NWC client
  • Throw clear, descriptive errors instead of failing later at runtime

This improves robustness and prevents misconfigured connection strings from causing downstream errors.

@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2026

Warning

Rate limit exceeded

@naveenkumar29052006 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@naveenkumar29052006
Copy link
Author

Hi @rolznz 👋
Whenever you have time, could you please take a look at this PR?

It adds validation for WalletConnect connection strings as discussed in #527.
Happy to make any changes if needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a method to validate a connection string (+ optionally require the secret field)

1 participant