Skip to content

Rename org members endpoint #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yeo-yeo merged 1 commit into from
Oct 2, 2023
Merged

Rename org members endpoint #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/client/components/UsersInChannelModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ function UserRow({
// it looks like nothing's happened in the FE atm
<DeleteButton
onClick={() => {
void update(`/channels/${org}`, 'DELETE', {
void update(`/channelMembers/${org}`, 'DELETE', {
userIDs: [user.id],
});
}}
Expand Down Expand Up @@ -191,7 +191,7 @@ function AddUsersToChannelModal({
// TODO: the org members API currently doesn't have subscriptions, so
// it looks like nothing's happened in the FE atm
const addUsers = useCallback(() => {
void update(`/channels/${channel.org}`, 'PUT', {
void update(`/channelMembers/${channel.org}`, 'PUT', {
userIDs: usersToAdd,
}).then(() => onClose());
}, [channel.org, onClose, update, usersToAdd]);
Expand Down
7 changes: 5 additions & 2 deletions src/server/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,11 @@ function main() {
app.get('/users', wrapAsyncHandler(handleGetCordUsers));
app.get('/usersData', wrapAsyncHandler(handleGetCordUsersData));

app.put('/channels/:channelName', wrapAsyncHandler(handleAddOrgMember));
app.delete('/channels/:channelName', wrapAsyncHandler(handleRemoveOrgMember));
app.put('/channelMembers/:channelName', wrapAsyncHandler(handleAddOrgMember));
app.delete(
'/channelMembers/:channelName',
wrapAsyncHandler(handleRemoveOrgMember),
);

app.put('/channels/:channelName', wrapAsyncHandler(handleAddChannel));

Expand Down