Merged
Conversation
lognaturel
reviewed
Jul 21, 2025
- linting changes: - RUF023 (unsorted-dunder-slots) new rule (affected many files) - PLC0415 imports at top of file (affected test_forms.py) - S320 previously ignored rule no longer exists so it is deleted
lindsay-stevens
force-pushed
the
update-deps
branch
from
5f3a5b7 to
53567d1
Compare
lognaturel
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been done to verify that this works as intended?
Ran tests + linter.
Why is this the best possible solution? Were any other approaches considered?
Last update was >6 months ago. Requests dependency spec was changed from
==to>=since this package seems to get security patches pretty frequently lately, so it seems like having pyodk block using a newer requests version is worse than the possibility of a functional incompatibility - in which case the user could specifically install an earlier requests version. The pydantic changes seem to be mainly performance, stability, etc.Linting changes:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should not be any functional changes.
Do we need any specific form for testing your changes? If so, please attach one.
N/A
Does this change require updates to documentation? If so, please file an issue here and include the link below.
N/A
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyodk testsandruff check pyodk teststo lint code