Skip to content

feat(landing): theme toggle support for landing #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anirudhprmar wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(landing): theme toggle support for landing #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e01e816
feat(landing): theme toggle support for landing
anirudhprmar May 12, 2026
b846ec2
fix(landing): add theme toggle to mobile nav view
anirudhprmar May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/app/(marketing)/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { PageTransition } from "@/components/layout/page-transition";
export default function MarketingLayout({ children }: { children: ReactNode }) {
return (
<CommandMenuProvider>
<div className="dark bg-background text-foreground min-h-dvh overflow-x-hidden">
<div className="bg-background text-foreground min-h-dvh overflow-x-hidden">
<NavigationBar stars={null} />
<main>
<PageTransition>{children}</PageTransition>
Expand Down
32 changes: 21 additions & 11 deletions apps/web/src/components/layout/navigation-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import { Button } from "@/components/ui/button";
import { BrandMenu } from "@/components/web/brand-menu";
import { URLs } from "@/lib/consts";

import { ThemeToggle } from "../theme-toggle";

// ─── Shared nav link ─────────────────────────────────────────────────

interface NavItem {
Expand Down Expand Up @@ -111,16 +113,19 @@ export function NavigationBar({ stars: _stars }: { stars: number | null }) {
>
<SectionShell className="flex items-center justify-between">
<BrandMenu linkClassName="gap-1 px-5 py-3" wordmarkClassName="scale-95" />
<button
type="button"
aria-label={mobileMenuOpen ? "Close navigation menu" : "Open navigation menu"}
aria-controls="mobile-navigation-menu"
aria-expanded={mobileMenuOpen}
onClick={() => setMobileMenuOpen((prev) => !prev)}
className="text-foreground/65 dark:text-foreground/50 hover:text-foreground/80 px-5 py-3 transition-colors"
>
{mobileMenuOpen ? <X size={18} /> : <Menu size={18} />}
</button>
<div className="flex items-center justify-center">
<ThemeToggle />
<button
type="button"
aria-label={mobileMenuOpen ? "Close navigation menu" : "Open navigation menu"}
aria-controls="mobile-navigation-menu"
aria-expanded={mobileMenuOpen}
onClick={() => setMobileMenuOpen((prev) => !prev)}
className="text-foreground/65 dark:text-foreground/50 hover:text-foreground/80 px-5 py-3 transition-colors"
>
{mobileMenuOpen ? <X size={18} /> : <Menu size={18} />}
</button>
</div>
</SectionShell>
</motion.div>

Expand All @@ -146,7 +151,11 @@ export function NavigationBar({ stars: _stars }: { stars: number | null }) {
key={item.name}
initial={{ opacity: 0, y: -4 }}
animate={{ opacity: 1, y: 0 }}
transition={{ duration: 0.2, delay: 0.05 + i * 0.03, ease: "easeOut" }}
transition={{
duration: 0.2,
delay: 0.05 + i * 0.03,
ease: "easeOut",
}}
>
<NavLink
item={item}
Expand Down Expand Up @@ -223,6 +232,7 @@ export function NavigationBar({ stars: _stars }: { stars: number | null }) {
<Github className="size-3.5" />
<span>GitHub</span>
</Button>
<ThemeToggle />
</div>
</div>
</SectionShell>
Expand Down
Loading