Skip to content

fix(consumer): Don't Crash Rust Consumer on Transport Error #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
george-sentry merged 2 commits into from
Apr 23, 2026
+20 −2
Merged

fix(consumer): Don't Crash Rust Consumer on Transport Error #535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb9a4ec
Don't Crash Rust Consumer on Transient `RD_KAFKA_RESP_ERR__TRANSPORT`…
george-sentry Apr 21, 2026
a1113ea
Rename Recoverable Error Function
george-sentry Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions rust-arroyo/src/backends/kafka/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ impl KafkaConsumerState {
}
}

/// Treat recoverable `librdkafka` errors as an empty poll the same way Python treats `KafkaError._TRANSPORT`.
fn kafka_error_is_recoverable(err: &KafkaError) -> bool {
matches!(
err,
KafkaError::MessageConsumption(RDKafkaErrorCode::BrokerTransportFailure)
| KafkaError::Global(RDKafkaErrorCode::BrokerTransportFailure)
)
}

fn create_kafka_message(topics: &[Topic], msg: BorrowedMessage) -> BrokerMessage<KafkaPayload> {
let topic = msg.topic();
// NOTE: We avoid calling `Topic::new` here, as that uses a lock to intern the `topic` name.
Expand Down Expand Up @@ -387,8 +396,17 @@ impl<C: AssignmentCallbacks> ArroyoConsumer<KafkaPayload, C> for KafkaConsumer<C

match res {
None => Ok(None),
Some(res) => {
let msg = create_kafka_message(&self.topics, res?);

Some(Err(err)) if kafka_error_is_recoverable(&err) => {
let error: &dyn std::error::Error = &err;
tracing::warn!(error, "Kafka poll transport error, retrying...");
Ok(None)
}

Some(Err(err)) => Err(err.into()),

Some(Ok(msg)) => {
let msg = create_kafka_message(&self.topics, msg);
self.offset_state
.lock()
.offsets
Expand Down
Loading