fix(deps): address smol-toml DoS vulnerability (GHSA-v3rj-xjv7-4jmq)#783
Merged
fix(deps): address smol-toml DoS vulnerability (GHSA-v3rj-xjv7-4jmq)#783
Conversation
Add pnpm override in docs/package.json to force smol-toml@^1.6.1, fixing a medium-severity DoS via deeply nested commented TOML lines. The vulnerable version (1.6.0) was a transitive dependency of astro and @astrojs/markdown-remark in the docs sub-project.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Dependabot alert #132.
smol-toml@1.6.0(transitive dependency ofastroand@astrojs/markdown-remarkin the docs sub-project) is vulnerable to a medium-severity DoS via TOML documents containing thousands of consecutive commented lines, causing a stack overflow from uncontrolled recursion.Fix: Add a pnpm override in
docs/package.jsonto forcesmol-toml@^1.6.1, which replaces the recursive comment parser with an iterative approach.No changes to the main Craft CLI — this only affects the docs site build dependencies.