ci: fix Node 20 + app-id deprecation warnings, refresh Node matrix#803
Merged
ci: fix Node 20 + app-id deprecation warnings, refresh Node matrix#803
Conversation
- Bump pnpm/action-setup from v4.3.0 (Node 20, deprecated) to v4.4.0 (Node 24) across build.yml, lint.yml, docs-preview.yml. SHA pin preserved per third-party action convention. - Rename 'app-id' to 'client-id' on actions/create-github-app-token@v3 step in release.yml; v3.1.0+ deprecates app-id. Value unchanged — SENTRY_RELEASE_BOT_CLIENT_ID is already a client ID. - Drop Node 20 from the build matrix, add Node 24. Warnings observed in run 24743422957.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes deprecation warnings surfaced in run 24743422957:
Node.js 20 actions are deprecated—pnpm/action-setup@v4.3.0runs on Node 20. Bumped to v4.4.0 which declaresusing: node24in itsaction.yml. Node 20 actions will be forced to Node 24 by 2026-06-02 and removed entirely by 2026-09-16.Input 'app-id' has been deprecated—actions/create-github-app-token@v3v3.1.0+ deprecatesapp-idin favour ofclient-id. TheSENTRY_RELEASE_BOT_CLIENT_IDvariable already holds a client ID, so only the input name changes.Also drops Node 20 from the build matrix (EOL 2026-04-30) and adds Node 24 for forward-compat coverage.
Changes
.github/workflows/build.yml['20','22']→['22','24']; bumppnpm/action-setuppin (×3) to v4.4.0.github/workflows/lint.ymlpnpm/action-setuppin to v4.4.0.github/workflows/docs-preview.ymlpnpm/action-setuppin to v4.4.0.github/workflows/release.ymlapp-id:→client-id:oncreate-github-app-token@v3Notes
pnpm/action-setupis third-party → SHA-pinned with trailing# v4.4.0comment, per the repo's pinning convention. SHA resolved viagit ls-remote … refs/tags/v4.4.0^{}.actions/create-github-app-tokenis GitHub-owned → stays on the@v3major tag (not SHA-pinned). v3 major already resolves past v3.1.0 which supportsclient-id.Verification
build.ymlwill run 2 matrix jobs (Node 22, Node 24) on push/PR — no more Node 20 warning.release.ymlworkflow_dispatchshould no longer emit theapp-iddeprecation warning.