fix(scheduler): Require schedule kind for create tool#614
Merged
Conversation
Require scheduler create calls to classify schedules as one_off or recurring before recurrence can be stored. This makes one-time reminders omit recurrence through the tool contract instead of relying on optional-field behavior. Fixes GH-610 Co-Authored-By: GPT-5 Codex <codex@openai.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduler create calls now require
schedule_kindso the model must classify a new task asone_offorrecurringbefore recurrence can be stored. This addresses one-time reminder requests accidentally getting a default recurrence while keeping the decision language-agnostic and avoiding natural-language parsing in the scheduler tool.The create tool now rejects inconsistent field combinations:
one_offwith anyrecurrence,recurringwithoutrecurrence, or missingschedule_kind. The scheduler spec and integration coverage were updated for the new model-facing contract.Validation run:
pnpm --filter @sentry/junior exec vitest run tests/integration/slack-schedule-tools.test.ts,pnpm typecheck, andpnpm --filter @sentry/junior-scheduler build.Fixes GH-610