feat: replace dynamic require() with static SVG import map for Vite/Astro support#226
Merged
sergical merged 3 commits intogetsentry:masterfrom Feb 25, 2026
Merged
Conversation
Dynamic `require()` with template literals doesn't work in Vite/esbuild (Astro). This adds a code generator that produces static imports for all 218 SVG icons in both sizes, so TypeScript compiles them to: - CJS: static require() calls (webpack/Gatsby compatible) - ESM: static import statements (Vite/Astro compatible) No change to the public API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- LG format now falls back to iconsLg["default"] instead of icons["default"] - preloadIcons filters out undefined entries from the icon map Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Prefix identifiers starting with a digit (e.g. "3d" → "_3d") - Fail generation if svg_80x80/ is missing icons present in svg/ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
elijames-codecov
approved these changes
Feb 23, 2026
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/generate-icons.js) that producessrc/icons.generated.tswith static imports for all 218 SVG icons in both sizes (436 total imports)require()with template literals inplatformIcon.tsxandpreload.tsxwith static import map lookupsrequire()calls (webpack/Gatsby compatible), ESM build produces staticimportstatements (Vite/Astro compatible)Why
Dynamic
require()with template literals (e.g.require(`../svg/${icon}.svg`)) works in webpack but breaks in Vite/esbuild (Astro) — the bundler can't resolve non-JS dynamic requires at build time, causing 436 errors.Test plan
yarn buildsucceeds with zero errorsbuild/icons.generated.jscontains staticrequire("../svg/foo.svg")callsesmbuild/icons.generated.jscontains staticimportstatementsrequire()is strictly more analyzable)🤖 Generated with Claude Code