Skip to content

feat: Add Effect.ts#230

Open
JPeer264 wants to merge 1 commit intomasterfrom
jp/add-effect
Open

feat: Add Effect.ts#230
JPeer264 wants to merge 1 commit intomasterfrom
jp/add-effect

Conversation

@JPeer264
Copy link
Member

Needed icon for the new Effect SDK: getsentry/sentry-javascript#19644

I hope the SVGs look fine

@JPeer264 JPeer264 requested a review from Jesse-Box March 13, 2026 07:33
@JPeer264 JPeer264 self-assigned this Mar 13, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

<path d="m71.5 43.3l-29.3 16.9q-0.3 0.2-0.7 0.3-0.5 0.1-0.9 0-0.4 0-0.8-0.2l-29.3-16.9c-0.9-0.5-1.1-1.3-1-2-0.3-1 0.1-1.9 1-2.4l29.3-16.8q0.3-0.2 0.8-0.3 0.4 0 0.9 0.1 0.3 0 0.7 0.2l29.3 16.8c0.8 0.5 1.2 1.4 1 2.3 0.1 0.7-0.2 1.5-1 2zm-5-2.1l-25.6-14.7-25.5 14.7 25.5 14.7z" />
<path d="m73 28.6c1.1-0.7 1.4-2.1 0.8-3.2-0.6-1-2-1.4-3.1-0.8l-29.8 17.2-29.7-17.1c-1.1-0.7-2.5-0.3-3.1 0.8-0.7 1.1-0.3 2.5 0.8 3.1l30.8 17.8q0.4 0.2 0.8 0.3 0.5 0 0.9-0.1 0.5-0.1 0.8-0.3z" />
<path d="m13.4 26.6l27.4-17.1 27.4 17.1-27.4 15.9z" />
<path d="m72.9 24.1c1.1 0.6 1.5 2 0.9 3.1-0.6 1.1-2 1.4-3.1 0.8l-29.8-17.1-29.7 17c-1.1 0.7-2.5 0.3-3.2-0.8-0.6-1.1-0.2-2.5 0.9-3.1l30.7-17.7q0.4-0.2 0.9-0.2 0.5-0.1 0.9 0 0.4 0.1 0.8 0.3z" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fill-rule="evenodd" in 80x80 SVG variant

Medium Severity

The svg/effect.svg (20x20) uses fill-rule="evenodd" on four of its five paths, but the svg_80x80/effect.svg (80x80) has no fill-rule="evenodd" on any path. This is especially problematic for the second path in each file, which contains a compound sub-path (the zm segment creating an inner diamond cutout). Without fill-rule="evenodd", the default nonzero rule may fill the inner cutout instead of rendering it as a hole, causing the 80x80 icon to look visually different from the 20x20 version.

Additional Locations (1)
Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant