chore(rrweb-player): Migrate to Svelte 5 and bump deps to resolve security alerts#280
Merged
chore(rrweb-player): Migrate to Svelte 5 and bump deps to resolve security alerts#280
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…all packages Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Preserves the original API contract where addEventListener handlers
receive { payload: value } rather than the unwrapped value.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
$derived is lazy in Svelte 5 and only evaluates when read. Since
percentage is only used inside {#if showController}, the progress
callback would stop firing when the controller is hidden. Move it
to a separate $effect to preserve the original eager behavior.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
In Svelte 4, $$props included all props so skipInactive was spread into the Replayer constructor. With $props() rest, it was excluded. This caused a race where autoPlay started before the $effect synced skipInactive to the Replayer config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e63110c. Configure here.
onceStylesheetLoaded returned early when link.sheet threw a SecurityError for CORS stylesheets, preventing the load listener from being attached and the _cssText mutation from being emitted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Lms24
approved these changes
Apr 15, 2026
| onMount(() => { | ||
| playerState = replayer.service.state.value; | ||
| speedState = replayer.speedService.state.value; | ||
| playerState = replayer.service.state.value as typeof playerState; |
Member
There was a problem hiding this comment.
l: why do we need the type casts here (and below)?
Member
Author
There was a problem hiding this comment.
The cast narrows string down to the expected union type.
| // for more information about preprocessors | ||
| preprocess: vitePreprocess(), | ||
|
|
||
| kit: { |
Member
There was a problem hiding this comment.
was this just a leftover? Didn't know we were using kit (?)
Member
Author
There was a problem hiding this comment.
I think this just came from scaffolding the proj, so basically a leftover yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate rrweb-player from Svelte 4 to Svelte 5 ($props, $derived, $effect, $state, callback props)
Security alerts resolved