Skip to content

feat: allow upgrade tests#4288

Open
aldy505 wants to merge 3 commits intomasterfrom
aldy505/feat/allow-upgrade-test
Open

feat: allow upgrade tests#4288
aldy505 wants to merge 3 commits intomasterfrom
aldy505/feat/allow-upgrade-test

Conversation

@aldy505
Copy link
Copy Markdown
Collaborator

@aldy505 aldy505 commented Apr 19, 2026

To be able to run upgrade tests against self-hosted, this is most useful to test database migrations

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

Changelog Preview

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Allow upgrade tests by aldy505 in #4288

🤖 This preview updates automatically when you update the PR.

Comment thread action.yaml Outdated
Comment thread action.yaml Outdated
Comment thread action.yaml Outdated
Comment thread action.yaml
@aldy505 aldy505 enabled auto-merge (squash) April 23, 2026 03:46
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 404e19e. Configure here.

Comment thread action.yaml
image="${image_urls[$i]}"
image_var=$(echo "${project}_IMAGE" | tr '[:lower:]' '[:upper:]')
echo "${image_var}=${image}" >> ${{ github.action_path }}/.env
done
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing newline causes empty element in readarray

Medium Severity

When callers pass multiline inputs using YAML | block scalar syntax (the standard way), the value includes a trailing newline. The <<< herestring adds another newline, so readarray -t produces an extra empty string element in both project_names and image_urls. The length check passes (both arrays have the same extra element), but the loop then writes a garbage _IMAGE= entry to the .env file. Using < <(printf '%s' "$PROJECT_NAME") instead of <<<"$PROJECT_NAME" would avoid this.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 404e19e. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant