fix(docker): install custom packages into runtime venv#4298
Open
KimSeoYeon23 wants to merge 1 commit intogetsentry:masterfrom
Open
fix(docker): install custom packages into runtime venv#4298KimSeoYeon23 wants to merge 1 commit intogetsentry:masterfrom
KimSeoYeon23 wants to merge 1 commit intogetsentry:masterfrom
Conversation
aldy505
approved these changes
Apr 25, 2026
Collaborator
aldy505
left a comment
There was a problem hiding this comment.
Looks good to me, let's see if the integration tests passed, and I'll merge
aminvakil
suggested changes
Apr 26, 2026
Collaborator
aminvakil
left a comment
There was a problem hiding this comment.
I do not think this should be merged.
upstream sentry Dockerfile uses /.venv/bin/ right now and sentry/Dockerfile in this repository already adapts that by executing pip as it is.
Although this does not harm right now, but we should keep up with pip in upstream sentry Dockerfile if we change this.
Right now there is no problem to be solved AFAICS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This installs custom Python packages into Sentry's runtime virtualenv instead of the
system Python.
self-hostedruns Sentry from/.venv, butsentry/Dockerfilewas installing thebundled nodestore extension with
pip, which targets the system interpreter. That canleave custom packages unavailable at runtime and cause the
webservice to fail duringstartup.
Root cause
The image build used:
RUN pip install ...while the actual Sentry runtime uses /.venv.
In my case, this caused the nodestore backend package to be installed outside the runtime
environment, which led to repeated web worker exits and an unhealthy web container.
Fix
Use /.venv/bin/pip for custom package installation in sentry/Dockerfile.
This updates:
Validation
After rebuilding the image and restarting the stack:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of
Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in
order to utilize my contributions in this here PR. So here's the deal: I retain all
rights, title and interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my contributions,
under Sentry's choice of terms.zhem