Skip to content

fix(snapshots): Rename generateTests to generateSnapshotTests #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runningcode merged 2 commits into from
Apr 16, 2026
+8 −7
Merged

fix(snapshots): Rename generateTests to generateSnapshotTests #1148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6a8334
fix(snapshots): Rename generateTests to generateSnapshotTests
runningcode Apr 16, 2026
c1208df
fix(snapshots): Fix spotless formatting
runningcode Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin-build/src/main/kotlin/io/sentry/android/gradle/AndroidComponentsConfig.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ private fun ApplicationVariant.configureSnapshotsTasks(

// Wire Paparazzi test generation and upload task when the Paparazzi plugin is applied
project.pluginManager.withPlugin("app.cash.paparazzi") {
if (extension.snapshots.generateTests.get()) {
if (extension.snapshots.generateSnapshotTests.get()) {
val android = project.extensions.getByType(BaseExtension::class.java)

project.dependencies.add(
Expand Down
3 changes: 2 additions & 1 deletion plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SnapshotsExtension.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ open class SnapshotsExtension @Inject constructor(objects: ObjectFactory) {

val enabled: Property<Boolean> = objects.property(Boolean::class.java).convention(false)

val generateTests: Property<Boolean> = objects.property(Boolean::class.java).convention(true)
val generateSnapshotTests: Property<Boolean> =
objects.property(Boolean::class.java).convention(true)

val includePrivatePreviews: Property<Boolean> =
objects.property(Boolean::class.java).convention(true)
Expand Down
10 changes: 5 additions & 5 deletions plugin-build/src/test/kotlin/io/sentry/android/gradle/extensions/SnapshotsExtensionTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,21 @@ class SnapshotsExtensionTest {
}

@Test
fun `generateTests is true by default`() {
fun `generateSnapshotTests is true by default`() {
val project = ProjectBuilder.builder().build()
val extension = project.objects.newInstance(SnapshotsExtension::class.java)

assertTrue(extension.generateTests.get())
assertTrue(extension.generateSnapshotTests.get())
}

@Test
fun `generateTests can be set to false`() {
fun `generateSnapshotTests can be set to false`() {
val project = ProjectBuilder.builder().build()
val extension = project.objects.newInstance(SnapshotsExtension::class.java)

extension.generateTests.set(false)
extension.generateSnapshotTests.set(false)

assertFalse(extension.generateTests.get())
assertFalse(extension.generateSnapshotTests.get())
}

@Test
Expand Down
Loading