-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(attributes): Add app.vitals.* attributes for mobile performance #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
buenaflor
merged 10 commits into
main
from
giancarlobuenaflor/add-app-start-ttid-ttfd-attributes
Apr 14, 2026
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9a42c5e
feat(attributes): Add app start and display timing attributes
buenaflor d0f5466
fix(attributes): Set pii to maybe for app timing attributes
buenaflor ddf3b25
feat(attributes): Add app.start, app.frames attributes and deprecate …
buenaflor bba6c80
feat(attributes): Deprecate time_to_initial_display and time_to_full_…
buenaflor 1ec65a7
fix(attributes): Address PR review feedback
buenaflor 6efd2d9
fix(attributes): Revert app.frames.delay.value type back to integer
buenaflor 03d84e3
ref(attributes): Move to app.vitals.* namespace and restore cold/warm…
buenaflor d7982e3
Merge branch 'main' into giancarlobuenaflor/add-app-start-ttid-ttfd-a…
buenaflor 897457d
fix(attributes): Correct changelog descriptions to use app.vitals.fra…
buenaflor 88ee441
fix(attributes): Correct changelog descriptions to use app.vitals.ttf…
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
19 changes: 19 additions & 0 deletions
19
model/attributes/app/app__vitals__frames__delay__value.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "key": "app.vitals.frames.delay.value", | ||
| "brief": "The sum of all delayed frame durations in seconds during the lifetime of the span. For more information see [frames delay](https://develop.sentry.dev/sdk/performance/frames-delay/).", | ||
| "type": "integer", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "alias": ["frames.delay"], | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": 5, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added app.vitals.frames.delay.value to replace frames.delay" | ||
| } | ||
| ] | ||
| } | ||
19 changes: 19 additions & 0 deletions
19
model/attributes/app/app__vitals__frames__frozen__count.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "key": "app.vitals.frames.frozen.count", | ||
| "brief": "The number of frozen frames rendered during the lifetime of the span.", | ||
| "type": "integer", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "alias": ["frames.frozen"], | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": 3, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added app.vitals.frames.frozen.count to replace frames.frozen" | ||
| } | ||
| ] | ||
| } |
19 changes: 19 additions & 0 deletions
19
model/attributes/app/app__vitals__frames__slow__count.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "key": "app.vitals.frames.slow.count", | ||
| "brief": "The number of slow frames rendered during the lifetime of the span.", | ||
| "type": "integer", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "alias": ["frames.slow"], | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": 1, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added app.vitals.frames.slow.count to replace frames.slow" | ||
| } | ||
| ] | ||
| } |
19 changes: 19 additions & 0 deletions
19
model/attributes/app/app__vitals__frames__total__count.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "key": "app.vitals.frames.total.count", | ||
| "brief": "The number of total frames rendered during the lifetime of the span.", | ||
| "type": "integer", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "alias": ["frames.total"], | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": 60, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added app.vitals.frames.total.count to replace frames.total" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "app.vitals.start.cold.value", | ||
| "brief": "The duration of a cold app start in milliseconds", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": 1234.56, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added app.vitals.start.cold.value attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "key": "app.vitals.start.type", | ||
| "brief": "The type of app start, for example `cold` or `warm`", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "alias": ["app_start_type"], | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": "cold", | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added app.vitals.start.type attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "app.vitals.start.warm.value", | ||
| "brief": "The duration of a warm app start in milliseconds", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": 1234.56, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added app.vitals.start.warm.value attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "key": "app.vitals.ttfd.value", | ||
| "brief": "The duration of time to full display in milliseconds", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "alias": ["time_to_full_display"], | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": 1234.56, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added app.vitals.ttfd.value attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "key": "app.vitals.ttid.value", | ||
| "brief": "The duration of time to initial display in milliseconds", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "alias": ["time_to_initial_display"], | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "example": 1234.56, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added app.vitals.ttid.value attribute" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "key": "time_to_full_display", | ||
| "brief": "The duration of time to full display in milliseconds", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": 1234.56, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "alias": ["app.vitals.ttfd.value"], | ||
| "deprecation": { | ||
| "replacement": "app.vitals.ttfd.value", | ||
| "reason": "Replaced by app.vitals.ttfd.value to align with the app.vitals.* namespace for mobile performance attributes", | ||
| "_status": "backfill" | ||
| }, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added and deprecated in favor of app.vitals.ttfd.value" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "key": "time_to_initial_display", | ||
| "brief": "The duration of time to initial display in milliseconds", | ||
| "type": "double", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": 1234.56, | ||
| "sdks": ["sentry.cocoa", "sentry.java.android", "sentry.javascript.react-native", "sentry.dart.flutter"], | ||
| "alias": ["app.vitals.ttid.value"], | ||
| "deprecation": { | ||
| "replacement": "app.vitals.ttid.value", | ||
| "reason": "Replaced by app.vitals.ttid.value to align with the app.vitals.* namespace for mobile performance attributes", | ||
| "_status": "backfill" | ||
| }, | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [313], | ||
| "description": "Added and deprecated in favor of app.vitals.ttid.value" | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.